ModDetectionPreventer icon indicating copy to clipboard operation
ModDetectionPreventer copied to clipboard

Mod causes resource pack distribution to fatally fail on Cytooxien

Open Kichura opened this issue 1 year ago • 29 comments

When joining Cytooxien with this mod enabled, it causes the resource pack distribution system to completely fail and cause the player to get kicked because there was an validation error - this does not occur when excluding this mod from the fabric client.

Guessing cytooxien patched your mod after all? 🙃

Kichura avatar Mar 12 '24 20:03 Kichura

Seems like it. For now I am not motivated enough to work on this, so it'll just like this on Cytooxien.

JustAlittleWolf avatar Mar 12 '24 21:03 JustAlittleWolf

I also could reproduce it with my own plugin which checks it (It just requires to have some strings that the plugin knows guranteed that they are present but aren't vanilla)

Onako2 avatar Mar 17 '24 11:03 Onako2

This should be fixed with the newest release 1.2.0

JustAlittleWolf avatar Mar 19 '24 19:03 JustAlittleWolf

I still have the error

linux-universe avatar Apr 25 '24 14:04 linux-universe

That is unfortunate, unfortunately Cytooxien has banned me so I am unable to check why the disconnect happens.

JustAlittleWolf avatar Apr 26 '24 16:04 JustAlittleWolf

Is it somehow possible to blacklist cytooxien from joining with the mod installed to protect other users, i was just banned too...

linux-universe avatar Apr 26 '24 17:04 linux-universe

I am not sure if that's the way to go, at that point you might as well uninstall the mod. For now I think that is also what you should do, to not use the mod. I'll put up a warning banner on GitHub and the download pages.

JustAlittleWolf avatar Apr 26 '24 18:04 JustAlittleWolf

Is it somehow possible to blacklist cytooxien from joining with the mod installed to protect other users, i was just banned too...

entirely banned? That's fucking shit

Onako2 avatar Apr 26 '24 20:04 Onako2

Is it somehow possible to blacklist cytooxien from joining with the mod installed to protect other users, i was just banned too...

entirely banned? That's fucking shit

i have sent a unban request. but yes permanent ban

linux-universe avatar Apr 26 '24 20:04 linux-universe

Should we inform the people behind Fabulously optimized that there is that issue?

Onako2 avatar Apr 26 '24 20:04 Onako2

Should we inform the people behind Fabulously optimized that there is that issue?

Great suggestion, I just informed them. Hopefully they'll take a look soon.

JustAlittleWolf avatar Apr 26 '24 21:04 JustAlittleWolf

Cytooxien has introduced a new check. They not only check for mod keybinds, but now also introduce keys themselves to block the fix from ModDetectionPreventer.

In my case it is for another mod - but it uses almost the same principle as ModDetectionPreventer. I logged all the keybinds that are translated on this check - then I noticed... morecreativetabs.other and morecreativetabs.wurst. These make no sense at all, so I decided to whitelist them and... it is fixed.

[06:00:32] [Render thread/INFO] (Minecraft) [STDOUT]: morecreativetabs.other -> Other
[06:00:32] [Render thread/INFO] (Minecraft) [STDOUT]: morecreativetabs.wurst -> Sausage
[06:00:32] [Render thread/INFO] (Minecraft) [STDOUT]: pack.source.fabricmod -> Fabric mod
[06:00:32] [Render thread/INFO] (Minecraft) [STDOUT]: sodium.option_impact.low -> Low

image

There are now two ways:

  • Block loading ModResourcePack to the TranslationStorage entirely - this only works for my use-case as I do not rely on their translation system.
  • Instead of only whitelisting Vanilla keybinds and translations rather listen for additional entries to the Translation Storage from RPs (that are not ModResourcePack).

I have a question though, does anyone know if this is fixed with Minecraft 1.20.5?

1zun4 avatar Apr 27 '24 04:04 1zun4

Cytooxien has introduced a new check. They not only check for mod keybinds, but now also introduce keys themselves to block the fix from ModDetectionPreventer.

In my case it is for another mod - but it uses almost the same principle as ModDetectionPreventer. I logged all the keybinds that are translated on this check - then I noticed... morecreativetabs.other and morecreativetabs.wurst. These make no sense at all, so I decided to whitelist them and... it is fixed.

[06:00:32] [Render thread/INFO] (Minecraft) [STDOUT]: morecreativetabs.other -> Other
[06:00:32] [Render thread/INFO] (Minecraft) [STDOUT]: morecreativetabs.wurst -> Sausage
[06:00:32] [Render thread/INFO] (Minecraft) [STDOUT]: pack.source.fabricmod -> Fabric mod
[06:00:32] [Render thread/INFO] (Minecraft) [STDOUT]: sodium.option_impact.low -> Low

image

There are now two ways:

* Block loading `ModResourcePack` to the `TranslationStorage` entirely - this only works for my use-case as I do not rely on their translation system.

* Instead of only whitelisting Vanilla keybinds and translations rather listen for additional entries to the Translation Storage from RPs (that are not ModResourcePack).

I have a question though, does anyone know if this is fixed with Minecraft 1.20.5?

It isn't fixed in 1.20.5/1.20.6

Onako2 avatar May 05 '24 16:05 Onako2

can you make a tutorial on youtube or smth? @Onako2

Schluerfmann avatar Jul 10 '24 20:07 Schluerfmann

can you make a tutorial on youtube or smth? @Onako2

What?

Onako2 avatar Jul 10 '24 20:07 Onako2

on how to fix this issue on cytooxien. Or did I get you wrong? Its too deep knowledge abt mods for me to really undertand what u wrote but I thought you had a solution for the stated problem

Schluerfmann avatar Jul 10 '24 21:07 Schluerfmann

on how to fix this issue on cytooxien. Or did I get you wrong? Its too deep knowledge abt mods for me to really undertand what u wrote but I thought you had a solution for the stated problem

I won't do a tutorial because I don't shoot in my own leg.

Onako2 avatar Jul 10 '24 21:07 Onako2

K srry for asking

Schluerfmann avatar Jul 10 '24 21:07 Schluerfmann

on how to fix this issue on cytooxien. Or did I get you wrong? Its too deep knowledge abt mods for me to really undertand what u wrote but I thought you had a solution for the stated problem

It's a shame that the mod that's supposed to be a ModDetectionPreventer doesn't fix this, even though I've provided the necessary solutions, but you could theoretically use LiquidBounce for this.

Oh @Onako2 "⚡ Fun fact: Makes Liquidbounce devs angry :)", who are you?

1zun4 avatar Jul 11 '24 00:07 1zun4

on how to fix this issue on cytooxien. Or did I get you wrong? Its too deep knowledge abt mods for me to really undertand what u wrote but I thought you had a solution for the stated problem

It's a shame that the mod that's supposed to be a ModDetectionPreventer doesn't fix this, even though I've provided the necessary solutions, but you could theoretically use LiquidBounce for this.

Oh @Onako2 "⚡ Fun fact: Makes Liquidbounce devs angry :)", who are you?

Could we talk about that last thing on Discord? onako2#0

Onako2 avatar Jul 11 '24 08:07 Onako2

if you cant get back into Cytooxien @JustAlittleWolf , PirateSoftware's blockgame server recently implemented the same detection method on their server and im getting the error that prevents me from joining due to the resource pack not downloading, it doesnt appear that his server bans anyone for logging on with any mods they dont allow, it just kicks them after a second, so if you want to run tests on whats going on, you can try it there

ill wait however long you want for a fix, or if someone else explains a fix i can just put it in myself may be easier

Chris-The-Lion avatar Aug 14 '24 22:08 Chris-The-Lion

if you cant get back into Cytooxien @JustAlittleWolf , PirateSoftware's blockgame server recently implemented the same detection method on their server and im getting the error that prevents me from joining due to the resource pack not downloading, it doesnt appear that his server bans anyone for logging on with any mods they dont allow, it just kicks them after a second, so if you want to run tests on whats going on, you can try it there

ill wait however long you want for a fix, or if someone else explains a fix i can just put it in myself may be easier

Resourcepack doesn't have anything? The server is just strange. Heard from a friend that the 800kb file downloaded 2 minutes. Zip doesn't contain anything relevant lol.

Onako2 avatar Aug 15 '24 22:08 Onako2

@Onako2 were you able to join the server with the mod installed? it alleges it cant grab the server resource pack, it seems to allow me to stay as long as i dont move, as soon as i move it kicks me. there is a crash screen that shows up but i cant get a capture of it before it reloads and gives me a different error message. if it doesnt do it with just that mod installed, add Journeymap to the mod list and join again and see if that works.

Chris-The-Lion avatar Aug 15 '24 23:08 Chris-The-Lion