jupiterbroadcasting.com icon indicating copy to clipboard operation
jupiterbroadcasting.com copied to clipboard

Add feedback button to episode and show pages

Open reesericci opened this issue 3 years ago • 9 comments

There should be an easy button to "send feedback" about the episode to the JB team, like on fireside.

reesericci avatar Jul 21 '22 12:07 reesericci

nice suggestion!

gerbrent avatar Jul 21 '22 16:07 gerbrent

The show pages already have the link. Are you expecting the contact page to open and autofill the show and episode?

harriseldon avatar Jul 26 '22 03:07 harriseldon

To be clear:

  • there are indeed 'email' icons+links on most of the Show pages
  • there are NOT any feedback method on Episode pages.

this feels like an acceptable Milestone 1.0 feature-set - but would be nice to have for Episode pages too.

image

gerbrent avatar Jul 28 '22 05:07 gerbrent

Hello, all. I have the template code for this worked out. I basically cloned ../themes/jb/layouts/partials/shows/links.html to ../themes/jb/layouts/partials/episode/links.html. Example: 2022-10-14_22-14

The change in the episode files is simple, but I am not sure where to add it. Example:

  "links": {
    "shownotes" : "https://extras.show/87/",
    "email" : "https://extras.show/contact",
    "twitter" : "https://twitter.com/jupiterextras",
    "youtube" : "https://www.youtube.com/playlist?list=PLUW3LUwQvegzkMxcqW0dslRJmumg6WrZi"
  },

duckunix avatar Oct 15 '22 03:10 duckunix

The change in the episode files is simple, but I am not sure where to add it.

So the shows links end up in the here and this translates to all the shows.

Someone who knows Hugo better than I can help you out, but I can provide a direction of how to tackle this.

Email, Twitter, and YouTube

All of these links are found in the in the links section of their respective shows folder. So in theory you can update your if statement to only look for those links and render them out

Shownotes

For the show notes link, you should be able to generate a per episode link by using the links.shownotes link of the show and the episode tag in the episodes markdown file to generate a link there. This way we don't need to update all the episode files to have these additional links.

CGBassPlayer avatar Oct 15 '22 13:10 CGBassPlayer

So the shows links end up in the here and this translates to all the shows.

Someone who knows Hugo better than I can help you out, but I can provide a direction of how to tackle this.

Found that which is where I cribbed thing from

Email, Twitter, and YouTube

All of these links are found in the in the links section of their respective shows folder. So in theory you can update your if statement to only look for those links and render them out

Yeah, I know some hugo, but not enough to pull vars from a different section. :(

Shownotes

For the show notes link, you should be able to generate a per episode link by using the links.shownotes link of the show and the episode tag in the episodes markdown file to generate a link there. This way we don't need to update all the episode files to have these additional links.

Good thought....let me see what I can figure out.

duckunix avatar Oct 15 '22 15:10 duckunix

@elreydetoda might be able to chime in with some wisdom on how to implement this idea as well

CGBassPlayer avatar Oct 15 '22 16:10 CGBassPlayer

Sorry, I was away from my computer yesterday. I'll try and take a look at this today 🙂

Thanks @duckunix , for taking this issue on!

elreydetoda avatar Oct 16 '22 13:10 elreydetoda

The change in the episode files is simple, but I am not sure where to add it.

So the shows links end up in the here and this translates to all the shows.

Someone who knows Hugo better than I can help you out, but I can provide a direction of how to tackle this.

Email, Twitter, and YouTube

All of these links are found in the in the links section of their respective shows folder. So in theory you can update your if statement to only look for those links and render them out

Shownotes

For the show notes link, you should be able to generate a per episode link by using the links.shownotes link of the show and the episode tag in the episodes markdown file to generate a link there. This way we don't need to update all the episode files to have these additional links.

This was some really awesome feedback @CGBassPlayer :partying_face: , I was on mobile before so I could appreciate the comprehensiveness of your comment before :sweat_smile:.

Even though you might not know how to do it, you've got the right thought pattern on how to keep things more DRY and re-using all the content that's already available in the content/repo :grin: very nicely done :rocket: :partying_face: :tada:

RE: how to do it, I'll be commenting inline or on the PR itself in a little bit @duckunix, but I just wanted to highlight @CGBassPlayer awesome guidance :blush:

elreydetoda avatar Oct 16 '22 14:10 elreydetoda