jsnapy icon indicating copy to clipboard operation
jsnapy copied to clipboard

fix for jsnapy username and password prompt

Open apurvaraghu opened this issue 3 years ago • 2 comments

Jsnapy prompt failing for password after giving username. Fix is to remove 'AND' clause with password and action field as None action is already handled and will cause 'AND' clause to fail otherwise.

apurvaraghu avatar Jul 14 '22 07:07 apurvaraghu

Please check what is the impact of removing "action is None" condition .

This doesn't break any part of the code and tests also pass successfully. Are there any other specific checks to confirm this?

apurvaraghu avatar Aug 17 '22 16:08 apurvaraghu

Please check what is the impact of removing "action is None" condition .

This doesn't break any part of the code and tests also pass successfully. Are there any other specific checks to confirm this?

Thanks , approved the changes , please merge .

chidanandpujar avatar Aug 18 '22 16:08 chidanandpujar