jsnapy
jsnapy copied to clipboard
Juniper
Code changes for #349 and #350.
What does this PR do?
The PR enhances the performances to parse testcase before hostname than doing individually for all devices. It doesn't change the functionality just optimises it. It also gives the developer an option to enhance logging which will be helpful in debugging process.
What issues does this PR fix or reference?
#349 and #350
Previous Behavior
Testcases were parsed everytime for multiple devices configured.
New Behavior
Testcases will be parsed once and then passed as an argument to all the devices to be connected.
Tests written?
Previous testcases were modified for new api.
Pull Request Test Coverage Report for Build 286
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 110 unchanged lines in 5 files lost coverage.
- Overall coverage decreased (-0.1%) to 92.236%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| /home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/jnpr/jsnapy/jsnapy.py | 22 | 93.29% |
| /home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/jnpr/jsnapy/jsnapy.py | 22 | 93.29% |
| /home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/jnpr/jsnapy/jsnapy.py | 22 | 93.29% |
| /home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/jnpr/jsnapy/jsnapy.py | 22 | 93.29% |
| /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/jnpr/jsnapy/jsnapy.py | 22 | 93.29% |
| <!-- | Total: | 110 |
| Totals | |
|---|---|
| Change from base Build 285: | -0.1% |
| Covered Lines: | 7888 |
| Relevant Lines: | 8552 |
💛 - Coveralls
Pull Request Test Coverage Report for Build 305
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 80 unchanged lines in 4 files lost coverage.
- Overall coverage decreased (-0.1%) to 92.261%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| /home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/jnpr/jsnapy/jsnapy.py | 20 | 93.91% |
| /home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/jnpr/jsnapy/jsnapy.py | 20 | 93.91% |
| /home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/jnpr/jsnapy/jsnapy.py | 20 | 93.91% |
| /home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/jnpr/jsnapy/jsnapy.py | 20 | 93.91% |
| <!-- | Total: | 80 |
| Totals | |
|---|---|
| Change from base Build 301: | -0.1% |
| Covered Lines: | 7916 |
| Relevant Lines: | 8580 |
