Use Java enums instead of static int

[xamino]

Example of what I mean here.

Instead of using some defined static integers, you could just use a Java enumeration. ~~This would allow code like here to be simplified to a nice switch statement for example.~~ Additionally it will allow type checking at compile time and avoid unwanted double assignment of specific integer values (for example the classical copy & paste error).

Basically nitpicking, but I think it would improve the code readability and maintainability quite a bit.

EDIT: Ups, bad example. If you're using Java 8 though that if-else construct can still be switched out to be a simple switch statement, see here.

EDIT2: In case it is not clear: you could replace many of the static declarations in Constants.java with parameterized enums like shown here.

[JumpMaster]

Hi Xamino,

I'm not a professional programmer but am always happy to learn. It seems that creating enums of string isn't straight forward. Strings are required for Intent actions. So I can't change much in Constants.

Also regarding the first example these are used to match BluetoothProfile.java. http://grepcode.com/file/repo1.maven.org/maven2/org.robolectric/android-all/4.4_r1-robolectric-1/android/bluetooth/BluetoothProfile.java

I started changing to an enum before realising.

I'm using Java 8 so switch statements make sense. First few changed as you can see here. https://github.com/JumpMaster/WheelLogAndroid/blob/master/app/src/main/java/com/cooper/wheellog/MainActivity.java#L126

Any other best practices are welcome!

[xamino]

Always glad to be of assistance!

Strings are required for Intent actions.

these are used to match BluetoothProfile.java

Ah yes, bluetooth. Shudder Okay – as I stated I was nitpicking anyway. :grin:

Wheel type also seems to be a good candidate to be "enumified", see here.

This is more of an architecture issue, so you might not want to change this, but I'll put it out there anyway. It may be nice to split KingSong and Gotway decoding logic into separate classes with a shared interface in a sub package. That way it would be trivial to add support for new wheels by simply adding a new class which implements the shared interface. Additionally it would move all wheel specific logic into clearly separated logical units and make the app more "general".

[JumpMaster]

I've changed WheelType to an enum. I like the interface idea. Will have to do some research to make sure it's implemented correctly. It's not something I've done before.