bentocache icon indicating copy to clipboard operation
bentocache copied to clipboard

feat(bentocache): Adding Drizzle ORM Adapters and Related Tests

Open moor-zhou opened this issue 10 months ago • 5 comments

moor-zhou avatar Apr 03 '25 09:04 moor-zhou

⚠️ No Changeset found

Latest commit: ea4e98223603d43f0cdab758f7f45bfa7cf01df3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 03 '25 09:04 changeset-bot[bot]

Thanks a lot! I will need a bit of time to review it and see if we can improve things Anyway thanks a lot, great feature to have!!

Julien-R44 avatar Apr 09 '25 14:04 Julien-R44

Thanks a lot! I will need a bit of time to review it and see if we can improve things Anyway thanks a lot, great feature to have!!

Thanks for the kind words! I’m glad you like the feature. Take your time with the review—I’d be happy to address any feedback or suggestions you might have to make it even better. Looking forward to hearing your thoughts!

moor-zhou avatar Apr 10 '25 03:04 moor-zhou

Alright, took some time to go through the code and I'll be honest, it's a bit overwhelming. Not your fault, I know it's pretty tricky to get clean Drizzle integrations. I had looked at other packages ( like NextAuth, or Lucia If i remember well ) that provided Drizzle integrations and honestly felt the same way.

That’s actually why I didn’t include Drizzle from the start (on top of the fact that I don’t use it myself). So yeah, sorry about that but I’m gonna need a bit more time : I’d like to do some refactor to try and make things a bit cleaner so it will be easier for me to maintain long-term

Julien-R44 avatar Apr 20 '25 19:04 Julien-R44

I completely understand! Drizzle can be incredibly tricky. Your plan to refactor is smart. If you hit any snags, let’s troubleshoot together.

moor-zhou avatar Apr 27 '25 07:04 moor-zhou