Julián Toledano

Results 31 comments of Julián Toledano

Hi @tac0turtle @jackzampolin I have been working on a Proof of Concept for a keyring that leverages HashiCorp plugins over gRPC. The code for this POC can be found in...

closing this in favor of #16637 once the ADR is approved we can create the related tasks

hey guys working on this as part of #18580 https://github.com/cosmos/cosmos-sdk/pull/20623/files#diff-5b2f1ae75a76aabad473106fc55d8dd20977e37eaa2e7a5404ab1d9af1d37ec9

After taking a look at this, I came to the conclusion that nested messages should be checked in their parent MsgHandler. The handler should always check: 1. can route any...

Benchmark results ``` goos: darwin goarch: arm64 pkg: [github.com/cosmos/cosmos-sdk/codec/address](http://github.com/cosmos/cosmos-sdk/codec/address) BenchmarkCodecWithCache BenchmarkCodecWithCache-8 19053944 60.81 ns/op 32 B/op 1 allocs/op BenchmarkCodecWithoutCache BenchmarkCodecWithoutCache-8 2752668 444.3 ns/op 96 B/op 2 allocs/op ```

for me its the other way around. I had to downgrade to 0.8.0 and now I'm getting that same message.

Not a big fan of setting this kind of logic in a decoder to be honest.

> we should a test done

I think this should be backported to 0.52 @julienrbrt