AzAdvertizer icon indicating copy to clipboard operation
AzAdvertizer copied to clipboard

Sync issues with community policies

Open maxime-roy opened this issue 1 year ago • 2 comments

Describe the bug Hi!

I think there might be an issue with the synchronization of the community policies. From AzAdvertizer, I'm not able to see the policy 4f8668bc-8adc-44fc-b6e1-20cf37dc6738, but it's available here on the main branch .

Thanks !

maxime-roy avatar May 03 '24 20:05 maxime-roy

ho!

good catch and thanks for reporting.

Checked and found three not synced policies, due to that the files are .jsonc whilst the syncer looks for .json (actually azurepolicy.json)

  • https://github.com/Azure/Community-Policy/tree/main/policyDefinitions/Tags/required-tag-and-value-set-on-subscriptions
  • https://github.com/Azure/Community-Policy/tree/main/policyDefinitions/Tags/required-tag-and-value-set-on-resource-groups
  • https://github.com/Azure/Community-Policy/tree/main/policyDefinitions/Tags/required-tag-and-value-set-on-resources

There seem no comments in the files at all, so changing the file extensions should be straight forward. Would you be willing to raise the PRs against the community repo?

JulianHayward avatar May 05 '24 18:05 JulianHayward

Will do!

Maybe at some point the syncer could support jsonc by stripping the comments before "ingesting it " ?

maxime-roy avatar May 07 '24 18:05 maxime-roy

@maxime-roy @JulianHayward Hi, we have presented a PR for this. Should be accepted in a couple of days. Thank you. https://github.com/Azure/Community-Policy/pull/452

DFRZ7 avatar May 29 '24 01:05 DFRZ7