Windows-screenFetch icon indicating copy to clipboard operation
Windows-screenFetch copied to clipboard

Missing Ascii Art Ending, Display resolution error and get-uptime alias

Open dominik-ba opened this issue 5 years ago • 3 comments

I know, I know this does look like a lot, but if you ignore the trailing white-spaces my vscode removes automatically when saving, the PR actually is not that much.

  1. I use a slightly different approach to get-uptime to address #37 and have a backwards compatible way of doing so.
  2. I do a check after all SystemInfoCollection was printed out to finalize the ascii art.
  3. I also fix #35 (at least for me). I have the assumption that the snippet
{
    return Get-Display;
[...]

simply was a unseen missing deletion or copy/past mistake. So I removed it and now it is working again. Additionally I put the "if single monitor" statement above the rest to get a tiny bit of speed improvement here for single monitor users.

I hope the code style etc. is fine for you. If you want some adjustments please tell me!

dominik-ba avatar Jul 07 '20 20:07 dominik-ba

I just noticed that with the .git files from the module of the Powershell store the identity got messed up. Will fix this as soon as I'm at my PC

dominik-ba avatar Jul 08 '20 05:07 dominik-ba

I just noticed that with the .git files from the module of the Powershell store the identity got messed up. Will fix this as soon as I'm at my PC

I just fixed the author to me.

dominik-ba avatar Jul 08 '20 09:07 dominik-ba

Can this be merged in? @JulianChow94

TheBlackPlague avatar May 20 '22 01:05 TheBlackPlague