lean.nvim icon indicating copy to clipboard operation
lean.nvim copied to clipboard

Add in fractional width/height and change default as per #315

Open lucianchauvin opened this issue 7 months ago • 4 comments

Not sure if this is the best way to go about this. Let me know if I should move some stuff around and/or change the defaults. refs #315

lucianchauvin avatar Jul 02 '25 22:07 lucianchauvin

Seems to work great, well done. Can you add another test for these fractional cases, you should be able to manipulate vim.o.lines I think before opening the infoview.

The CI flakiness on macOS is unfortunately still not fixed until I remove the Mathlib dependency somehow, but the pre-commit failures are real: https://results.pre-commit.ci/run/github/325645198/1751495304.Pg-zXgoRT0aWUrWJDcKMYg (and telling you you need local function res_dim.)

Julian avatar Jul 03 '25 13:07 Julian

Hey @lucianchauvin the CI flakiness should be resolved if you merge main, lemme know if you're still interested in adding the test!

Julian avatar Jul 15 '25 12:07 Julian

Hey @lucianchauvin the CI flakiness should be resolved if you merge main, lemme know if you're still interested in adding the test!

I've fixed the issue that the pipeline caught. For the tests, would you like me to just add two:

  • one that opens the infoview horizontally and checks that its lines correspond to the percent
  • another one for vertical with columns

lucianchauvin avatar Jul 17 '25 18:07 lucianchauvin

would you like me to just add two

Yeah those two sound perfect to me!

Julian avatar Jul 17 '25 19:07 Julian

Thanks for writing the tests!

lucianchauvin avatar Dec 21 '25 15:12 lucianchauvin