Add in fractional width/height and change default as per #315
Not sure if this is the best way to go about this. Let me know if I should move some stuff around and/or change the defaults. refs #315
Seems to work great, well done. Can you add another test for these fractional cases, you should be able to manipulate vim.o.lines I think before opening the infoview.
The CI flakiness on macOS is unfortunately still not fixed until I remove the Mathlib dependency somehow, but the pre-commit failures are real: https://results.pre-commit.ci/run/github/325645198/1751495304.Pg-zXgoRT0aWUrWJDcKMYg (and telling you you need local function res_dim.)
Hey @lucianchauvin the CI flakiness should be resolved if you merge main, lemme know if you're still interested in adding the test!
Hey @lucianchauvin the CI flakiness should be resolved if you merge main, lemme know if you're still interested in adding the test!
I've fixed the issue that the pipeline caught. For the tests, would you like me to just add two:
- one that opens the infoview horizontally and checks that its lines correspond to the percent
- another one for vertical with columns
would you like me to just add two
Yeah those two sound perfect to me!
Thanks for writing the tests!