MultipleScattering.jl

MultipleScattering.jl copied to clipboard

This pull request sets the compat entry for the `Statistics` package to `1`. This keeps the compat entries for earlier versions. Note: I have not tested your package with this...

github-actions[bot]

This pull request changes the compat entry for the `StaticArrays` package from `^0.8, ^0.9, ^0.10, ^0.11, 0.12` to `^0.8, ^0.9, ^0.10, ^0.11, 0.12, 1`. This keeps the compat entries for...

github-actions[bot]

suggestion: meshes.jl interop

1

that would really increase the number of supported shapes and would be in line with what seems to be the most supported shape library in julia

alok

RFC: Include example of vector waves (such as electromagnetism or elasticity)

1

Currently the machinery should work for acoustics, which is a scalar equation. But we have not yet tested for any physics with a FieldDim > 1. Without a test case...

jondea

Remove parameter T from most all parametric types

5

The type `T`, used to indicate the type of numbers used, i.e. Float64, FLoat32, etc.. appear in many parametric types: ```julia Shape{T

arturgower

FrequencySimulationResult, FrequencySimulation, and basis order

4

This is just to debate out current types. Am not sure how useful is the type `FrequencySimulation` now. Essentially it is not just an added step were the user always...

arturgower

Quite a lot of functions are missing docstrings, and most with docstrings are missing the function signatures. See [Julia documentation](https://docs.julialang.org/en/stable/manual/documentation/) for recommendations on how to write docstring.

jondea

When calling name on a shape, like this: ```julia name(shape::Circle) = "Circle" ``` coverage says that it is [not covered](https://coveralls.io/builds/17369411/source?filename=src/shapes/circle.jl#L11) but it is [called in tests](https://github.com/jondea/MultipleScattering.jl/blob/7c0164906919b64569041882d78a21845f26f937/test/shapetests.jl#L25). I also have the...

jondea

Simple interface for plot field for both time and frequency

8

I think the following should work: - `plot(SimulationResult)` should return several lines plots for each x - `plot(SimulationResult, linetype=:contour)` should attempt a contour plot. This should work for both `TimeSimulationResult`...

arturgower