Make decode() interface accept AbstractVector

Open jdonnerstag opened this issue 5 years ago • 1 comments

Hi,

we are working a lot with @view/SubArray on top of a larger buffer. Currently the decode() function requires a Vector{UInt8} argument. For us it means we need to copy the data in an inner, performance optimized, loop. In case there is no specific reason, would it possible to change the interface to support AbstractVector{UInt8}?

thanks a lot

Nov 19 '20 14:11 jdonnerstag

Maybe I've been overly restrictive. Can you make a PR to use AbstractVector (with tests to check that it works)?

Nov 25 '20 09:11 nalimilan