StatsBase.jl icon indicating copy to clipboard operation
StatsBase.jl copied to clipboard

Histogram fit does not exploit structure in edges

Open KeithWM opened this issue 3 years ago • 1 comments

When the edges provided to the histogram fit function have the form of a StepRangeLen, this structure can be exploited to compute the bins for each data point much more quickly. I originally intended to create a PR right away, but I'm a bit unsure about how this combined with the in-built multidimensionality of the histograms. I also have some doubts whether the functionality really does not yet exist.

KeithWM avatar Jan 06 '23 16:01 KeithWM

I originally intended to create a PR right away, but I'm a bit unsure about how this combined with the in-built multidimensionality of the histograms.

Steps are one-dimensional in Julia, so you can just write a method for the 1d case and ignore the rest.

I also have some doubts whether the functionality really does not yet exist.

If it does, you'll get a method ambiguity error when you try to define it :smile:

ParadaCarleton avatar Jun 27 '23 01:06 ParadaCarleton