PDMats.jl icon indicating copy to clipboard operation
PDMats.jl copied to clipboard

Other factorizations: parametrization or new names?

Open timholy opened this issue 2 years ago • 1 comments

Based on https://github.com/mateuszbaran/CovarianceEstimation.jl/issues/90 we're likely to want something like PDMat that supports different factorizations. Two factorizations are currently under discussion:

  • Eigen
  • SymWoodbury with a Diagonal or UniformScaling "main matrix" (A in https://en.wikipedia.org/wiki/Woodbury_matrix_identity)

Both of these can be efficiently checked for positive (semi) definiteness and would seem to fit here. There seem to be multiple instantiations, though: should the existing PDMat be renamed PDCholesky? Or should we add a F<:Factorization{T} parameter? Either is workable, I'm opening this largely to ask for guidance about your preferences.

CC @mateuszbaran

timholy avatar Nov 20 '23 18:11 timholy

We are about to unify PDMat and PDSparseMat in #188. This will already introduce a F<:Factorization type parameter, so extending PDMats to other factorizations will be much simpler after this change.

devmotion avatar Nov 20 '23 19:11 devmotion