DimensionalityReduction.jl icon indicating copy to clipboard operation
DimensionalityReduction.jl copied to clipboard

MDS type not defined

Open jpfairbanks opened this issue 11 years ago • 1 comments

The function mds(D::Array{T,2}) at DimensionalityReduction/src/mds.jl:22 returns a type MDS(X, D, k) which is not defined in the package. The typedef was removed in commit cbbbfcab8f19e891e77380cdd12eed8ddee50e13. Was this an accident or an intended removal of a feature?

jpfairbanks avatar Mar 14 '14 18:03 jpfairbanks

Here is a diff of my ~/.julia/DimensionalityReduction/src/types.jl to add the type back in. The file test/mds.jl still does not work because Error: dist not defined.

index b10f81a..5727d91 100644
--- a/src/types.jl
+++ b/src/types.jl
@@ -6,6 +6,12 @@ type PCA
     cumulative_variance::Vector{Float64}
 end

+type MDS
+    X::Matrix
+    D::Matrix{Float64}
+    k::Int
+end
+
 type ICA
     S::Matrix{Float64}
     H::Matrix{Float64}

jpfairbanks avatar Mar 14 '14 18:03 jpfairbanks