LinearOperators.jl icon indicating copy to clipboard operation
LinearOperators.jl copied to clipboard

Separate 5-args constructor

Open geoffroyleconte opened this issue 2 years ago • 5 comments

geoffroyleconte avatar Jul 07 '23 17:07 geoffroyleconte

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8a4bba3) 96.57% compared to head (8f52b9b) 96.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   96.57%   96.48%   -0.09%     
==========================================
  Files          15       15              
  Lines        1051     1053       +2     
==========================================
+ Hits         1015     1016       +1     
- Misses         36       37       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 07 '23 17:07 codecov[bot]

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
PROPACK.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

github-actions[bot] avatar Jul 07 '23 17:07 github-actions[bot]

I needed to remove the constructor LinearOperator{T}(.....) and replace it with LinearOperator(::Type{T}, ....) where {T} because it would not work for LinearOperator5{T}(......), but this is a breaking change.

geoffroyleconte avatar Jul 07 '23 18:07 geoffroyleconte

@geoffroyleconte Any ideas where this comes from: https://github.com/JuliaSmoothOptimizers/LinearOperators.jl/actions/runs/7107666583/job/19349546057?pr=282

dpo avatar Dec 05 '23 23:12 dpo