DistributedFactorGraphs.jl icon indicating copy to clipboard operation
DistributedFactorGraphs.jl copied to clipboard

Missing field: BlobEntry.acquisitionTime

Open dehann opened this issue 3 years ago • 5 comments

TAC

  • add field to data entry

dehann avatar Jan 25 '23 20:01 dehann

xref:

  • https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/issues/985

dehann avatar Mar 17 '23 17:03 dehann

Is that not the timestamp field? Why both?

Affie avatar Mar 17 '23 18:03 Affie

Yep, I made it simply timestamp, that work for everyone?

The automated fields are lastUpdatedTimetstamp and createdTimestamp.

On Fri, Mar 17, 2023 at 1:27 PM Johannes Terblanche < @.***> wrote:

Is that not the timestamp field? Why both?

— Reply to this email directly, view it on GitHub https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/issues/939#issuecomment-1474240031, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUJO2YTKQDZSV6LPXLXDWDW4SUILANCNFSM6AAAAAAUGXT5XA . You are receiving this because you are subscribed to this thread.Message ID: @.*** .com>

GearsAD avatar Mar 17 '23 21:03 GearsAD

ah, missed the last comment -- so confirming:

  • BlobEntry.timestamp is the same as .acquisitionTimestamp when a blob is created at the edge.
  • createdTimestamp is as the name suggests (unclear if this created at the edge or when synced to server, assuming the latter).
  • lastUpdatedTimestamp ... if a mutation happens for something specific like assigning a .blobId upon server upload.

dehann avatar Mar 27 '23 18:03 dehann

I don't think createdTimestamp is intended to be set by the user but I'ts something interesting to consider in the offline use case.

Affie avatar Mar 27 '23 19:03 Affie