DistributedFactorGraphs.jl icon indicating copy to clipboard operation
DistributedFactorGraphs.jl copied to clipboard
verified publisher icon JuliaRobotics

Deprecated subgraph functions in CGDFG

Open Affie opened this issue 5 years ago • 3 comments

https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/blob/eaea68c09d712532a2ad73338b0298da43e0e37a/src/CloudGraphsDFG/services/CloudGraphsDFG.jl#L465-L492

see

  • https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/pull/373
  • https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/issues/300
  • https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/pull/376

Affie avatar Aug 31 '20 12:08 Affie

hi, thanks for finding this. although this needs work, i would recommend deferring the effort in the short term and only return to consolidate cgdfg subgraph when it becomes really necessary or sensible to do so. If we can limp along on current cgdfg implementation for a while, that should be okay.

dehann avatar Aug 31 '20 18:08 dehann

It looks like more of a maintenance thing with the functions missed with the deletion of the deprecations.

However, CGDFG can still overwrite buildSubgraph and/or copyGraph! for performance.

Affie avatar Aug 31 '20 19:08 Affie

Also listing here in case it isn't/hasn't been elsewhere for DFG:

  • https://juliagraphs.org/LightGraphs.jl/latest/operators/#LightGraphs.egonet-Union{Tuple{U},%20Tuple{T},%20Tuple{AbstractGraph{T},Integer,Integer,AbstractArray{U,2}}}%20where%20U%3C:Real%20where%20T%3C:Integer
  • https://juliagraphs.org/LightGraphs.jl/latest/operators/#LightGraphs.induced_subgraph-Union{Tuple{U},%20Tuple{AG},%20Tuple{AG,AbstractArray{U,1}}}%20where%20U%3C:Integer%20where%20AG%3C:AbstractGraph

dehann avatar Sep 02 '20 02:09 dehann