RandomExtensions.jl icon indicating copy to clipboard operation
RandomExtensions.jl copied to clipboard

`random_staticarrays` does not work in Julia 1.9

Open fingolfin opened this issue 2 years ago • 1 comments

I am right now updating the README (PR will come shortly). Doing so I noticed that the README suggests:

julia> RandomExtensions.random_staticarrays() # poor man's conditional modules!
# ugly warning

But I don't get an ugly warning, I get an error, no matter what I try (and looking at the code, it is exactly the error I would expect):

julia> RandomExtensions.random_staticarrays() # poor man's conditional modules!
ERROR: ArgumentError: Package RandomExtensions does not have StaticArrays in its dependencies:
- You may have a partially installed environment. Try `Pkg.instantiate()`
  to ensure all packages in the environment are installed.
- Or, if you have RandomExtensions checked out for development and have
  added StaticArrays as a dependency but haven't updated your primary
  environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with RandomExtensions
Stacktrace:
 [1] macro expansion
   @ ./loading.jl:1634 [inlined]
 [2] macro expansion
   @ ./lock.jl:267 [inlined]
 [3] require(into::Module, mod::Symbol)
   @ Base ./loading.jl:1611
 [4] eval
   @ ./boot.jl:370 [inlined]
 [5] random_staticarrays()
   @ RandomExtensions ~/.julia/dev/RandomExtensions/src/sampling.jl:558
 [6] top-level scope
   @ REPL[4]:1

It looks to me as if this should be redone using a package extension (or perhaps Requires.jl for older Julia versions) ?

fingolfin avatar Oct 10 '23 16:10 fingolfin

Yes, I noticed too that it was now failing, it should totally be re-done with package extensions. It used to emit a warning, but was still working in some older julia versions.

rfourquet avatar Oct 12 '23 10:10 rfourquet