pyjulia icon indicating copy to clipboard operation
pyjulia copied to clipboard

adding the trace-compile option to the julia initialization

Open rdyro opened this issue 2 years ago • 5 comments

It'd be nice to be able to trace the compilation performed by Julia called via PyJulia. The main use case is for the precompilation of a Julia library triggered primarily through their Python interface.

The change is a single line adding the trace-compile option.

rdyro avatar May 05 '23 22:05 rdyro

Thanks. Could you work on updating the tests?

mkitti avatar May 06 '23 08:05 mkitti

I'll take a look and push another commit soon, thanks!

rdyro avatar May 06 '23 15:05 rdyro

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (69b734f) 85.22% compared to head (7bd924f) 87.60%. Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   85.22%   87.60%   +2.37%     
==========================================
  Files          39       40       +1     
  Lines        2342     2364      +22     
==========================================
+ Hits         1996     2071      +75     
+ Misses        346      293      -53     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '23 16:05 codecov[bot]

I fixed all errors in existing tests and I added a new test specifically for the new trace_compile option.

If you can take a look now, that'd be great. @mkitti

rdyro avatar May 07 '23 22:05 rdyro

I think with the additional test, this should look better now. Thanks for taking a look @MilesCranmer

rdyro avatar Jan 17 '24 23:01 rdyro