PyPlot.jl icon indicating copy to clipboard operation
PyPlot.jl copied to clipboard

PyObject use numpy_ma.array to plot masked missings

Open deszoeke opened this issue 1 year ago • 3 comments

fixes #593 tests to be added later

deszoeke avatar Dec 10 '24 01:12 deszoeke

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 22.13%. Comparing base (343cec5) to head (9792c98).

Files with missing lines Patch % Lines
src/PyPlot.jl 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   22.31%   22.13%   -0.19%     
==========================================
  Files           4        4              
  Lines         363      366       +3     
==========================================
  Hits           81       81              
- Misses        282      285       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 10 '24 01:12 codecov-commenter

Thank you, @deszoeke, for making the PR :-)

if you need a (trivial) test:

using Test
@test PyObject([1,missing]).mask[2]

Alexander-Barth avatar Dec 10 '24 08:12 Alexander-Barth

Automatic checks fail (on ubuntu and windows) because fragile PyCall builds fail.

@Alexander-Barth wrote:

if you need a (trivial) test:

using Test
@test PyObject([1,missing]).mask[2]

Testing of PyPlot is quite minimal. PR deszoeke:patch-2 adds a test of plot.

deszoeke avatar Dec 10 '24 17:12 deszoeke