Dagger.jl icon indicating copy to clipboard operation
Dagger.jl copied to clipboard

Stop tracking the manifest files

Open JamesWrigley opened this issue 1 year ago • 4 comments

I don't think these really need to be tracked, and they cause conflicts whenever the manifest is changed and you switch branch or something.

JamesWrigley avatar Mar 18 '24 22:03 JamesWrigley

This generally LGTM - do you know why the docs build is failing? Maybe the default settings changed upstream? We need to be able to skip some of these missing doc checks until we get that fully fixed up.

jpsamaroo avatar Mar 20 '24 15:03 jpsamaroo

Ahh yes, that'll be because #482 is fixed now that ProfileSVG.jl has been updated, so now the docs will be using Documenter.jl v1 which has stricter defaults. I'll update the docs :)

JamesWrigley avatar Mar 20 '24 21:03 JamesWrigley

Fixed in 518a4b0 and 85df3cb, so this should fix #482 too now.

JamesWrigley avatar Mar 20 '24 23:03 JamesWrigley

A bunch of other jobs are still broken, but I don't think that's caused by the manifest being deleted, and it should be working in #463, sooooo I don't think I'll bother fixing that :see_no_evil:

JamesWrigley avatar Mar 20 '24 23:03 JamesWrigley

Thanks!

Yes those jobs were previously failing, but I haven't had the chance to look into them.

jpsamaroo avatar Mar 21 '24 19:03 jpsamaroo