Example.jl icon indicating copy to clipboard operation
Example.jl copied to clipboard

Update the CI

Open Nosferican opened this issue 6 years ago • 10 comments

The example showcases how to set up the CI using Travis CI (GitHub app), Codecov, and Documenter.

Nosferican avatar Sep 04 '19 20:09 Nosferican

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f968c69). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #47   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?      2           
  Branches          ?      0           
=======================================
  Hits              ?      2           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f968c69...b32b018. Read the comment docs.

codecov-io avatar Sep 04 '19 20:09 codecov-io

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f968c69). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #47   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?      2           
  Branches          ?      0           
=======================================
  Hits              ?      2           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f968c69...b32b018. Read the comment docs.

codecov-io avatar Sep 04 '19 20:09 codecov-io

Any objections?

Nosferican avatar Sep 09 '19 14:09 Nosferican

Why remove AV?

fredrikekre avatar Sep 09 '19 15:09 fredrikekre

It is using Travis to run Windows x64/x86 jobs. Those jobs are a bit slower at the moment, but that way it just needs one CI service that runs all the test matrix (linux, osx, win / 64-bit and 32-bit infrastructures).

Nosferican avatar Sep 09 '19 15:09 Nosferican

I agree. In my experience setting up AppVeyor is tricky, I can never remember how to do it. Also organizations cannot have accounts, which is a problem when there are several maintainers or when the original maintainer steps back.

nalimilan avatar Sep 09 '19 19:09 nalimilan

In my experience setting up AppVeyor is tricky, I can never remember how to do it.

It really isn't anymore, it is IMO much easier than Travis if you use AppVeyor.jl.

Also organizations cannot have accounts, which is a problem when there are several maintainers or when the original maintainer steps back.

This is not true anymore. I set it up for JuliaSparse some 5 months ago for Metis.jl: https://github.com/JuliaSparse/Metis.jl

fredrikekre avatar Sep 10 '19 09:09 fredrikekre

OK, nice to hear. Still setting up two CI services is more work than setting up a single one, and Travis CI is the only one to support Windows, Linux and Mac currently.

Anyway we could keep the script, and just note that people don't need to enable both.

nalimilan avatar Sep 10 '19 10:09 nalimilan

Technically Azure also allows for all three OS / architectures, but currently it is pretty involved. Keeping the AppVeyor script seems like it would be more confusing than the potential benefit. How about putting a comment on how other CI are available and we can link to the documentation for setting up AppVeyor and Azure?

Nosferican avatar Sep 10 '19 13:09 Nosferican

Bump

Nosferican avatar Sep 25 '19 13:09 Nosferican