Example.jl icon indicating copy to clipboard operation
Example.jl copied to clipboard
verified publisher icon JuliaLang

Giving love (updates)

Open Nosferican opened this issue 6 years ago • 5 comments

  • Use OSI standardized license text so it is machine detectable by GitHub/Licensee
  • Update CI by including Windows (x64/x86) through Travis
  • Update Codecov example (is codecov enabled for the repo?)
  • Using current Pkg.jl format for test/docs stages
  • Added example of using/import statements
  • Added Weave for docs

Nosferican avatar Aug 20 '19 16:08 Nosferican

  • Use OSI standardized license text so it is machine detectable by GitHub/Licensee

This now doesn't match what is generated by PkgTemplates and Pkg.generate, however.

StefanKarpinski avatar Aug 20 '19 16:08 StefanKarpinski

We should make the changes to PkgTemplates and Pkg.generate to use the OSI standard texts rather a custom text which is not machine detectable.

Nosferican avatar Aug 20 '19 17:08 Nosferican

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f968c69). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #44   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?      5           
  Branches          ?      0           
=======================================
  Hits              ?      5           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/Example.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f968c69...910079d. Read the comment docs.

codecov-io avatar Aug 20 '19 17:08 codecov-io

Can you split the PR into smaller pieces? That will help merging the less controversial changes soon. I'd like the question of the standard format to use for LICENSE.md to be settled here before switching other packages (as you propose in your PRs).

nalimilan avatar Sep 04 '19 08:09 nalimilan

I have split the changes into #45, #46, #47, and #48. I can open another one for the using/import example since it is an issue that comes up often in the Slack.

Nosferican avatar Sep 04 '19 20:09 Nosferican