Distributed.jl icon indicating copy to clipboard operation
Distributed.jl copied to clipboard

Add RemoteLogger

Open theogf opened this issue 1 year ago • 3 comments

Closes https://github.com/JuliaLang/Distributed.jl/issues/52

This is the port from https://github.com/JuliaLang/julia/pull/48121 by @simonbyrne .

I mostly reused the code from the PR, if that's not okay let me know I'll just close this PR.

I also did not made the modification on using this as a default for new workers as this would be unexpected behaviour.

theogf avatar Mar 14 '24 09:03 theogf

I mostly reused the code from the PR, if that's not okay let me know I'll just close this PR.

You could acknowledge @simonbyrne by adding a line

Co-authored-by: simonbyrne <[email protected]>

to a commit message.

fatteneder avatar Jul 18 '24 21:07 fatteneder

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.23%. Comparing base (af89e6c) to head (1857e37).

Files with missing lines Patch % Lines
src/logger.jl 88.88% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   79.14%   79.23%   +0.08%     
==========================================
  Files          10       11       +1     
  Lines        1899     1907       +8     
==========================================
+ Hits         1503     1511       +8     
  Misses        396      396              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 20 '24 13:07 codecov[bot]

As mentioned in the original PR, this feels a bit lacking without support for scopes :thinking: If there's significant demand I would be ok with merging it under a Distributed.Experimental submodule with the understanding that the behaviour would change in the future when scopes become supported.

WRT supporting scopes I kinda like the idea here about RemoteScopedValue: https://github.com/JuliaLang/julia/issues/35757#issuecomment-1712010224

@vchuravy, @jpsamaroo, any thoughts?

JamesWrigley avatar Dec 13 '24 21:12 JamesWrigley