IntervalRootFinding.jl icon indicating copy to clipboard operation
IntervalRootFinding.jl copied to clipboard

Remove old code

Open dpsanders opened this issue 7 years ago • 3 comments

Remove old code:

  • [x] bisection.jl

  • [x] move out definitions of N used in branch_and_prune

  • [ ] krawczyk.jl

  • [ ] newton.jl

  • [ ] find_roots stuff

dpsanders avatar Mar 12 '18 05:03 dpsanders

Is the code in newton1d.jl still considered maintained and part of the current API ?

Kolaru avatar Mar 04 '19 23:03 Kolaru

That was added in last year's GSoC project.

In a way it's useful to have a separate code, but the actual code itself is long and convoluted. We should see if anything is salvagable and probably get rid of the rest.

cc @eeshan9815

dpsanders avatar Mar 04 '19 23:03 dpsanders

If I recall correctly, it worked well for complicated functions, and functions which had a lot of multiple roots, where the existing solver sometimes struggled. So, should it be implemented as a part of the roots interface and kept as a different keyword solver?

eeshan9815 avatar Mar 09 '19 18:03 eeshan9815