ImageView.jl icon indicating copy to clipboard operation
ImageView.jl copied to clipboard

Switch to test/Project.toml

Open IanButterworth opened this issue 4 years ago • 6 comments

IanButterworth avatar Jan 14 '22 15:01 IanButterworth

Codecov Report

Merging #260 (b61eeff) into master (23c3808) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   66.94%   66.94%           
=======================================
  Files           7        7           
  Lines         944      944           
=======================================
  Hits          632      632           
  Misses        312      312           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23c3808...b61eeff. Read the comment docs.

codecov[bot] avatar Jan 14 '22 15:01 codecov[bot]

What's the advantage? I can't find it now, but a recent conversation I only skimmed between Shuhei & @KristofferC suggested little advantage (which has been my experience).

timholy avatar Jan 14 '22 22:01 timholy

Well, this was prompted because when I did

pkg> test ImageView

sometime during test execution it complained about some of the test deps not being installed. I think ones that FileIO used indirectly, QuartzImageIO etc.

This format doesn't do that and installed everything upfront.

Maybe that's a Pkg bug though

IanButterworth avatar Jan 14 '22 22:01 IanButterworth

Hmm, interesting. I don't see why they'd be different, but I haven't dug into it.

timholy avatar Jan 14 '22 22:01 timholy

Me neither. I'll try to come up with a MWE for Pkg

IanButterworth avatar Jan 14 '22 22:01 IanButterworth

sometime during test execution it complained about some of the test deps not being installed

That sounds weird.. Would be good to track that down indeed.

KristofferC avatar Jan 14 '22 22:01 KristofferC

Closing as stale

IanButterworth avatar Dec 21 '22 02:12 IanButterworth