Formatting.jl icon indicating copy to clipboard operation
Formatting.jl copied to clipboard

Improved string safety, and slight performance considerations

Open jakewilliami opened this issue 4 years ago • 0 comments

  • Improved string safety by using SubString, prevind, nextind, firstindex, and lastindex where possible.
  • Made performance improvements by changing findfirst(isequal(c), str) to findfirst(c, str) (no allocating, much faster), and by searching for isdigit instead of using regex within addcommas. Using SubString also seemed to be faster.

All tests passing. Please let me know if you need anything else :slightly_smiling_face:

jakewilliami avatar Sep 30 '21 07:09 jakewilliami