FileIO.jl icon indicating copy to clipboard operation
FileIO.jl copied to clipboard

Added .sms to registry

Open laurentbartholdi opened this issue 2 years ago • 6 comments

laurentbartholdi avatar Sep 11 '23 20:09 laurentbartholdi

Codecov Report

Patch and project coverage have no change.

Comparison is base (05ebb3f) 90.98% compared to head (b18c74c) 90.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files          10       10           
  Lines         710      710           
=======================================
  Hits          646      646           
  Misses         64       64           
Files Changed Coverage Δ
src/registry.jl 95.26% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 11 '23 20:09 codecov[bot]

Indeed it's not (yet) registered. I just submitted to the registrator, https://github.com/JuliaRegistries/General/pull/97356

On Thu, 14 Dec 2023 at 18:35, Steve Kelly @.***> wrote:

@.**** requested changes on this pull request.

In src/registry.jl https://github.com/JuliaIO/FileIO.jl/pull/380#discussion_r1427032836:

@@ -531,3 +531,6 @@ add_format(format"QOI", "qoif", ".qoi", [:QOI => UUID("4b34888f-f399-49d4-9bb3-4

Bibliography files.

add_format(format"BIB", (), [".bib"], [:Bibliography => UUID("f1be7e48-bf82-45af-a471-ae754a193061")]) + +# sparse matrices +add_format(format"SMS", (), ".sms", [:Spasm => UUID("017bf598-072c-475c-a75e-c3e68736ce70")])

This doesn't appear to be a registered package?

— Reply to this email directly, view it on GitHub https://github.com/JuliaIO/FileIO.jl/pull/380#pullrequestreview-1782334595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARAQUBYYYDTMRP7263WIITYJM2FFAVCNFSM6AAAAAA4T3ZUEWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBSGMZTINJZGU . You are receiving this because you authored the thread.Message ID: @.***>

-- Laurent Bartholdi laurent.bartholdigmailcom Fachrichtung Informatik+Mathematik, Universität des Saarlandes Postfach 151150, 66041 Saarbrücken, Germany Tel. +49 681 3023227, Sekr. +49 681 3023430

laurentbartholdi avatar Dec 18 '23 20:12 laurentbartholdi