GraphPlot.jl icon indicating copy to clipboard operation
GraphPlot.jl copied to clipboard

Kamada kawai

Open BCRARL opened this issue 6 years ago • 4 comments

Adds kamada_kawai_layout, which uses the graph-theoretic distance as the equilibrium distance between two vertices. The starting point can be supplied or will be generated from a call to shell_layout with shells corresponding to successive next-neighbor shells starting with the highest degree vertex. Disconnected graphs are placed side by side.

BCRARL avatar Jun 20 '19 15:06 BCRARL

Codecov Report

Merging #89 into master will decrease coverage by 3.07%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   32.02%   28.95%   -3.08%     
==========================================
  Files           9       10       +1     
  Lines         509      563      +54     
==========================================
  Hits          163      163              
- Misses        346      400      +54     
Impacted Files Coverage Δ
src/KamadaKawai.jl 0.00% <0.00%> (ø)
src/layout.jl 44.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b8c963...394a3cb. Read the comment docs.

codecov[bot] avatar Jun 24 '19 17:06 codecov[bot]

I incorporated the comments as seemed appropriate. Optim is part of JuliaOpt. Putting in an independent non-linear optimization implementation is not a good use of time and resources. I haven't added any tests as I am unfamiliar with how that works for visualizations.

BCRARL avatar Jun 24 '19 17:06 BCRARL

@simonschoelly I've addressed most of your concerns, I belive. Is there anything in particular holding back the inclusion?

BCRARL avatar Jul 29 '19 12:07 BCRARL

@simonschoelly, any thoughts on this PR. It seems that @BCRARL addressed the review points back in 2019.

hdavid16 avatar Jul 25 '22 18:07 hdavid16