Gtk.jl icon indicating copy to clipboard operation
Gtk.jl copied to clipboard

Test issues windows

Open tknopp opened this issue 7 years ago • 8 comments

I have setup appveyor and the good thing is that Gtk (at julia 0.7) basically builds on windows. However, there are some pretty funny test errors:

https://ci.appveyor.com/project/tknopp/gtk-jl/build/job/wp61rfx4xueufg8c

Seems to be a general Gtk issue.

tknopp avatar Aug 15 '18 15:08 tknopp

Pango tools took three tries to download. The next library failed on try five of five. Try again?

With good hope for gtk on windows, good luck!

Den ons. 15. aug. 2018, 17:03 skrev Tobias Knopp [email protected]:

I have setup appveyor and the good thing is that Gtk (at julia 0.7) basically builds on windows. However, there are some pretty funny test errors:

https://ci.appveyor.com/project/tknopp/gtk-jl/build/job/wp61rfx4xueufg8c

Seems to be a general Gtk issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JuliaGraphics/Gtk.jl/issues/362, or mute the thread https://github.com/notifications/unsubscribe-auth/ANTatCtqNtKdJoXYRqAF1EMGM5aZuQS7ks5uRDg5gaJpZM4V-Qxb .

hustf avatar Aug 15 '18 15:08 hustf

@hustf: no not that one, have a look at that one: https://ci.appveyor.com/project/tknopp/gtk-jl/build/1.0.2/job/wp61rfx4xueufg8c

All is ok, the only issue is that the window size is wrong.

tknopp avatar Aug 15 '18 16:08 tknopp

Windows tries to "let us" specify a number of different screen units, so some round-off is expected. This was a huge round-off, which will occur with tiny windows. Perhaps rewrite the checks to accept both? Something like @check windowsize in [400, 464]

Btw., I am trying to reproduce locally, but struggle a bit with the new package manager. Julia starts building automatically, and cancelling that process lead me to loose my git head. Is there an easy way to avoid that? Sorry for asking in the wrong place.

hustf avatar Aug 15 '18 18:08 hustf

I can reproduce locally, with the same test numbers as in the appveyor logs. Unfortunately, however, the REPL starts to show output very, very slow. Which I believe is an old issue with Gtk on Windows. This was on Julia 0.7 run in a cygwin (mintty terminal) window.

There is another way to launch Julia on Windows, directly from the windows explorer. With this approach, the tests behave slightly differently. Some windows are initially launched in full-screen mode. There is none of the terrible slow-down from the cygwin-launched Julia. The test output is the same as in appveyor and cygwin.

hustf avatar Aug 15 '18 18:08 hustf

Would you like a PR with the changes? If so, to master?

hustf avatar Aug 15 '18 18:08 hustf

I prefer to disable the tests on windows. Have done so in the last commit.

tknopp avatar Aug 15 '18 19:08 tknopp

I don't get these size issues on my Windows 7 (both starting from VS Code or the terminal). I guess disabling the tests is fine for now, I doubt anybody relies on getting these values exactly.

jonathanBieler avatar Aug 16 '18 09:08 jonathanBieler

Thanks Jonathan, good to hear that this is not a real problem. There are more important tasks to move Gtk.jl forward. So as this is "fixed" I will close the issue.

tknopp avatar Aug 16 '18 10:08 tknopp