Clipper.jl icon indicating copy to clipboard operation
Clipper.jl copied to clipboard

Interface with more functions from ClipperLib

Open plut opened this issue 5 years ago • 2 comments

(this is more a feature request than a true issue...)

Reading the documentation from ClipperLib, this library supports Minkowski sum and difference:

http://www.angusj.com/delphi/clipper/documentation/Docs/Units/ClipperLib/Functions/MinkowskiSum.htm

However these are not interfaced by Clipper.jl. I looked up a bit and neither are they present in libcclipper (this is not surprising). Since these two functions are quite useful, it would be nice to have them exported in Clipper.jl!

plut avatar Jan 08 '21 22:01 plut

So I have written some code that makes these two functions (Minkowski sum and difference) visible in the Clipper_jll.jl library. What is the procedure for submitting a PR on this topic? Should I send the PR directly to Yggdrasil (who will review it then)? How is it then propagated to Clipper_jll.jl (is there an auto-build?)

plut avatar Oct 01 '21 19:10 plut

That sounds about right. A PR to Yggdrasil, once merged, will update the _jll. Please tag me in the Yggdrail PR so I can test locally before merge in Yggdrasil.

sjkelly avatar Oct 03 '21 00:10 sjkelly