ForwardDiff.jl icon indicating copy to clipboard operation
ForwardDiff.jl copied to clipboard
verified publisher icon JuliaDiff

Fix seeding with undefined elements

Open devmotion opened this issue 11 months ago • 4 comments

Fixes #436. Fixes #740.

devmotion avatar Apr 07 '25 20:04 devmotion

I didn't know about isassigned, this seems appropriate. Could this cause a slowdown in the vast majority of cases where similar actually assigns stuff?

gdalle avatar Apr 07 '25 20:04 gdalle

Could this cause a slowdown in the vast majority of cases where similar actually assigns stuff?

I put it behind an isbitstype check, so it should never be hit for bit types (such as Float64, Float32, Duals of Float64, Complex of FloatXY, etc.)

devmotion avatar Apr 07 '25 21:04 devmotion

What's the word on this one? Do we want it?

gdalle avatar May 03 '25 08:05 gdalle

gentle bump from me as well

pkofod avatar Jun 08 '25 12:06 pkofod

Bump again

pkofod avatar Aug 24 '25 07:08 pkofod

I guess let's go with _unsetindex! for now then. 👍

KristofferC avatar Aug 25 '25 08:08 KristofferC

I opened https://github.com/JuliaLang/julia/issues/59394 regarding unsetindex!.

KristofferC avatar Aug 25 '25 20:08 KristofferC