AbstractDifferentiation.jl icon indicating copy to clipboard operation
AbstractDifferentiation.jl copied to clipboard

Create Invalidations.yml

Open ranocha opened this issue 3 years ago • 5 comments

This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.

See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29

ranocha avatar Sep 01 '22 15:09 ranocha

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eb5d913) 83.33% compared to head (b540142) 83.82%. Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   83.33%   83.82%   +0.49%     
==========================================
  Files           6        6              
  Lines         474      476       +2     
==========================================
+ Hits          395      399       +4     
+ Misses         79       77       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 25 '23 14:09 codecov[bot]

@ranocha the action seems to error, do you know what's the problem?

devmotion avatar Sep 25 '23 14:09 devmotion

I hav enever seen that before 🤷 The stacktrace suggests something in Pkg went wrong... the highest level is Pkg.add(pkgs::Vector{String})

ranocha avatar Sep 25 '23 18:09 ranocha

I've seen it in multiple repos but I've never spent time trying to figure why the action is broken in some repos and works in others.

devmotion avatar Sep 26 '23 10:09 devmotion

For instance, it errors also in the ForwardDiff repo (https://github.com/JuliaDiff/ForwardDiff.jl/pull/665) and AbstractFFTs (https://github.com/JuliaMath/AbstractFFTs.jl/pull/121).

devmotion avatar Sep 26 '23 10:09 devmotion