AbstractDifferentiation.jl icon indicating copy to clipboard operation
AbstractDifferentiation.jl copied to clipboard

Regression in type inferrability

Open gdalle opened this issue 2 years ago • 5 comments

When I bumped AbstractDifferentiation compat to 0.6 on ImplicitDifferentiation, I got type inference errors in ChainRulesTestUtils that were not there before. Probably a regression due to the latest changes. Any idea what might have worsened inference @devmotion ? https://github.com/gdalle/ImplicitDifferentiation.jl/actions/runs/6659445596/job/18098532825

gdalle avatar Oct 27 '23 06:10 gdalle

Are you sure that these are caused by AbstractDifferentiation? Was the AbstractDifferentiation update the only change compared with e.g. runs on the master branch? I wonder because, e.g., the latest Zygote release (0.6.67) also contains a few more fundamental changes (getindex adjoints were removed in favour of ChainRules).

devmotion avatar Oct 27 '23 07:10 devmotion

I'll see if the tests still fail with the previous Zygote, thanks for the tip

gdalle avatar Oct 30 '23 06:10 gdalle

I just checked, reverting to Zygote v0.6.66 doesn't fix things, but reverting to AbstractDifferentiation v0.5.3 does.

gdalle avatar Nov 10 '23 16:11 gdalle

Can you post an MWE?

mohdibntarek avatar Mar 13 '24 11:03 mohdibntarek

Unfortunately it was buried inside the ImplicitDifferentiation.jl test suite, and I didn't have time to investigate, so I just deactivated the inference tests to be able to update to [email protected] in the compat

gdalle avatar Mar 13 '24 20:03 gdalle