DBInterface.jl icon indicating copy to clipboard operation
DBInterface.jl copied to clipboard

Declare whole interface as as public

Open frankier opened this issue 1 year ago • 5 comments

This is already useful in practice with e.g. https://github.com/ericphanson/ExplicitImports.jl which will give false positives for using private implementation at the moment.

frankier avatar Feb 19 '25 13:02 frankier

@spaette Cheeky ping.

Hopefully this is an uncontroversial change/easy merge. Let me know if I can add any assurance.

frankier avatar Apr 01 '25 07:04 frankier

https://discourse.julialang.org/

Perhaps feedback could be solicited on the subject matter from the above online discussion venue for Julia.

spaette avatar Apr 01 '25 14:04 spaette

Thanks for the information. It is quite a small change so I'll ping @quinnj first, but if there is some problem, I can take it to Discourse if they agree it would be useful.

frankier avatar Apr 03 '25 08:04 frankier

@oxinabox

Would you consider the subject matter of the PR having implications beyond the scope of a single Julia package?

spaette avatar Apr 03 '25 22:04 spaette

@quinnj

Time permitting would you provide a second review?

spaette avatar May 06 '25 23:05 spaette