DataTables.jl icon indicating copy to clipboard operation
DataTables.jl copied to clipboard

duplicate functionality in merge! and hcat!

Open cjprybol opened this issue 8 years ago • 2 comments

AFAICT merge! and hcat! do the same thing. Should we export hcat! and deprecate merge!?

cjprybol avatar Apr 12 '17 21:04 cjprybol

If anything I would do it the other way around: keep merge!, since that's the familiar name for this operation, and deprecate hcat!, since that's more reminiscent of Julia matrix terminology.

ararslan avatar Apr 12 '17 21:04 ararslan

Sounds good to me! It's also easier to change the internal function names than it is to change all the code out in the wild that uses merge!. When I open the PR for this I'll add something to the docs to help users choose between hcat, merge!, and full outer join which all allow users to merge tables but do so in different ways. I just found out about merge! while reviewing tests for the #30 refactor.

cjprybol avatar Apr 12 '17 22:04 cjprybol