SymbolicControlSystems.jl icon indicating copy to clipboard operation
SymbolicControlSystems.jl copied to clipboard

Remove dependency on SymPy.jl

Open ufechner7 opened this issue 2 years ago • 6 comments

For me SymPy.jl fails to compile on 2 of 3 PCs. Second best option would be https://github.com/jverzani/SymPyPythonCall.jl/, best option not being dependent on Python.

ufechner7 avatar Oct 10 '23 01:10 ufechner7

SymPy is a fundamental core dependency of this package and this will not be changed

baggepinnen avatar Oct 10 '23 03:10 baggepinnen

First question: Which feature does SymPy.jl provide that SymPyPythonCall.jl doesn't provide?

Second question: Which features are missing in Symbolics.jl for implementing the conversion of a symbolic s expression into a transfer function?

ufechner7 avatar Oct 11 '23 11:10 ufechner7

Which feature does SymPy.jl provide that SymPyPythonCall.jl doesn't provide?

I don't know, and since this package is working perfectly fine on my machine and on the CI runner, I cannot motivate spending time figuring it out.

Which features are missing in Symbolics.jl for implementing the conversion of a symbolic s expression into a transfer function?

I don't know, Symbolics is missing a lot of features, like documentation, stability and maturity.

baggepinnen avatar Oct 11 '23 12:10 baggepinnen

https://github.com/JuliaPy/PythonCall.jl is the future...

ufechner7 avatar Oct 11 '23 12:10 ufechner7

I cannot motivate spending time figuring it out.

The question is, would you accept a pull request that replaces PyCall with PythonCall?

ufechner7 avatar Oct 11 '23 12:10 ufechner7

I have nothing against switching, I just cannot motivate spending time on it. If you submit a PR that makes the change (and that change alone), that'd be fine by me

baggepinnen avatar Oct 11 '23 12:10 baggepinnen