gRPCClient.jl icon indicating copy to clipboard operation
gRPCClient.jl copied to clipboard

tag 1.0 with ProtoBuf pinned to working version

Open tanmaykm opened this issue 1 year ago • 2 comments

gRPCClient.jl requires ProtoBuf v0.11. It is incompatible with 1.x versions of ProtoBuf as it was a significant rewrite and protobuf services are not yet supported there. This PR is to pin ProtoBuf version requirement to v0.11 and tag a new release of gRPCClient.

tanmaykm avatar Feb 22 '24 08:02 tanmaykm

Not sure why codegen is failing in CI. Things seem to work fine locally. Trying to dig into it

tanmaykm avatar Feb 22 '24 10:02 tanmaykm

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.84%. Comparing base (f4ccd52) to head (79c747b).

Files Patch % Lines
src/grpc.jl 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   91.90%   91.84%   -0.06%     
==========================================
  Files           5        5              
  Lines         321      331      +10     
==========================================
+ Hits          295      304       +9     
- Misses         26       27       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 23 '24 18:02 codecov-commenter