FemtoCleaner.jl icon indicating copy to clipboard operation
FemtoCleaner.jl copied to clipboard

Incorrect bot action in invenia/Memento.jl

Open femtocleaner[bot] opened this issue 6 years ago • 1 comments

@ararslan has indicated an incorrect bot action in https://github.com/invenia/Memento.jl/pull/110 The relevant snippets are shown below:

@@ -78,7 +78,7 @@ mutable struct EC2Record <: Record
         trace = Attribute{StackTrace}(get_trace)
 
         EC2Record(
-            Attribute{DateTime}(() -> round(time, Dates.Second)),
+            Attribute{DateTime}(() -> round(time, digits=Dates.Second)),
@@ -98,7 +98,7 @@ mutable struct CSVFormatter <: Formatter
     delim::Char
     vals::Array{Symbol}
 
-    CSVFormatter(delim=',', vals=Array{Symbol}()) = new(delim, vals)
+    CSVFormatter(delim=',', vals=Array{Symbol}(undef)) = new(delim, vals)

femtocleaner[bot] avatar Feb 21 '19 20:02 femtocleaner[bot]

I had the round() one today, in https://github.com/cormullion/TickTock.jl/pull/1 . But you already know about it, don't you femtocleaner? :)

cormullion avatar Mar 26 '19 16:03 cormullion