Deprecations.jl icon indicating copy to clipboard operation
Deprecations.jl copied to clipboard

squeeze

Open bjarthur opened this issue 7 years ago • 2 comments

am i correct in thinking Femtocleaner.jl could handle squeeze by adding these lines to Deprecations.jl/src/database/simple.jl?

    @add_rename squeeze         dropdims           v"0.7.0-DEV.????" [true,false]
 
    match(KeywordsUnlocked,
        "dropdims(\$A, \$dims)",
        "dropdims(\$A, dims=\$dims!)",
        filter = keyword_default_filter
    )

bjarthur avatar Sep 19 '18 00:09 bjarthur

and that moreover Femotocleaner.jl can't handle the dims keyword in mean, std etc. because there are two-argument methods of each for which the second argument is not the region, and that all Deprecations.jl is really doing it pattern matching, not parsing the AST?

bjarthur avatar Sep 19 '18 00:09 bjarthur

and that all Deprecations.jl is really doing it pattern matching, not parsing the AST?

Well, it's pattern matching on the AST ;) - for those simple matchers at least. There's more complicated matchers and transformers.

Keno avatar Sep 21 '18 04:09 Keno