Memoize.jl icon indicating copy to clipboard operation
Memoize.jl copied to clipboard

Memoize does not work for bigint

Open kessido opened this issue 5 years ago • 3 comments

I wanted to let you know that @memoize for function that recive bigint does not act as expected.

image

kessido avatar Feb 02 '21 23:02 kessido

Yes, I suppose that is a consequence of the IdDict default. Does it work if you @memoize Dict() function f(x) ...?

cstjean avatar Feb 03 '21 11:02 cstjean

Yes, Tho I would suggest using Dict by default then as it add some underling logic prone to bugs.

image

kessido avatar Feb 04 '21 20:02 kessido

Yeah... I didn't make that call. It would be a breaking change, but I think I agree with you there. IdDict is IMO premature optimization for this package.

cstjean avatar Feb 05 '21 11:02 cstjean