EndpointRanges.jl icon indicating copy to clipboard operation
EndpointRanges.jl copied to clipboard

Now in Base

Open PallHaraldsson opened this issue 6 years ago • 4 comments

[skip ci]

PallHaraldsson avatar Apr 23 '20 12:04 PallHaraldsson

Maybe deprecate this package (as we do want users to adopt this style?), or not, as Julia LTS still important. If I recall, it's in Julia 1.4, and e.g. begin, not ibegin.

PallHaraldsson avatar Apr 23 '20 12:04 PallHaraldsson

You'll need a more nuanced statement, try the view example in the README without using ibegin.

timholy avatar Apr 23 '20 14:04 timholy

It's not just that the syntax is different. This can do stuff that Base can't, and vice versa. Like I said, try to get the view example in the README to work without using this package.

I'm all in favor of updating the README with information about the improvements in Julia itself, it's just that the statement has to be accurate.

timholy avatar May 26 '20 20:05 timholy

I think you could pull the latest commit (and not complicate my text further; people could see here on mix-and match).

Not too important thoughts: I just thought/assumed your package completely redundant. I'm not actually using the package.

I thought it regrettable if people use this package, with non-standard "syntax" (strictly speaking completely Julia syntax). I guess you can and must mix and match new syntax, and e.g. your view on different (or same lines).

You could even mix like, while I guess not advised:

a[1:(begin+iend)÷2] == a[1:10]

PallHaraldsson avatar May 27 '20 10:05 PallHaraldsson