SingularIntegralEquations.jl icon indicating copy to clipboard operation
SingularIntegralEquations.jl copied to clipboard

`hilbert(S::Space{<:PeriodicLine},f,z)` calls domain`(f::AbstractVector)`

Open mjp98 opened this issue 3 years ago • 1 comments

On line 14 of periodicline.jl there appears to be a typo, leading to a call to domain(f::AbstractVector) which is not defined.

function hilbert(S::Space{<:PeriodicLine},f::AbstractVector,z::Number)
    S2=setdomain(S,Circle())
    hilbert(S2,f,mappoint(domain(f),Circle(),z))-hilbert(S2,f,-1)
end

I think the last line should read hilbert(S2,f,mappoint(domain(S),Circle(),z))-hilbert(S2,f,-1)?

A similar issue occurs on line 24. I would be happy to put together a pull request to fix this.

mjp98 avatar Jul 26 '22 21:07 mjp98

Great, thanks!

dlfivefifty avatar Jul 27 '22 08:07 dlfivefifty