FastTransforms.jl icon indicating copy to clipboard operation
FastTransforms.jl copied to clipboard
verified publisher icon JuliaApproximation

Remove DSP dependency

Open MikaelSlevinsky opened this issue 3 years ago • 2 comments

Removing DSP from FastTransforms reduces the load time from 3.7 s to 2.8 s for me, a 25% savings. @dlfivefifty, is there any downstream reason not to remove DSP?

MikaelSlevinsky avatar Jul 20 '22 03:07 MikaelSlevinsky

I thought we need it for conv ?

dlfivefifty avatar Jul 20 '22 11:07 dlfivefifty

If https://github.com/JuliaDSP/DSP.jl/pull/477 gets merged, then generic convolution will have nothing to do with this repository.

MikaelSlevinsky avatar Jul 20 '22 18:07 MikaelSlevinsky

This issue will be closed today with a patch release since https://github.com/JuliaDSP/DSP.jl/pull/477 has been merged, FastTransforms re-exports GenericFFT, and ToeplitzMatrices (a FastTransforms dependency) has been tagged (https://github.com/JuliaMatrices/ToeplitzMatrices.jl/commit/c6f3a2487448e642e18db10b7e39090c432b3300) to ensure the newest DSP patch or greater, [0.7.7, 0.8.0), is loaded.

MikaelSlevinsky avatar Aug 23 '22 18:08 MikaelSlevinsky

That is, no loss of features (no breaking changes) for the user.

MikaelSlevinsky avatar Aug 23 '22 18:08 MikaelSlevinsky