FastTransforms.jl icon indicating copy to clipboard operation
FastTransforms.jl copied to clipboard

No tests for nufft routines

Open gwater opened this issue 5 years ago • 1 comments

Tests only cover nudft routines which are not exported/acvertised in documentation. As a result nufft2 is unusable without any indication from tests.

gwater avatar Jan 28 '21 12:01 gwater

Not sure that's true. This test uses the direct transforms to establish a comparison https://github.com/JuliaApproximation/FastTransforms.jl/blob/8625a440488c79e40355ab966bb805dc9650cfde/test/nuffttests.jl#L50-L52

MikaelSlevinsky avatar Jan 28 '21 16:01 MikaelSlevinsky

It looks like nufft2 works now and there is some minimal documentation.

To prevent nufft2 from breaking again in the future, I nevertheless recommend some direct test coverage.

gwater avatar Aug 02 '23 11:08 gwater