MLJBase.jl icon indicating copy to clipboard operation
MLJBase.jl copied to clipboard

Run CI on Julia nightly

Open DilumAluthge opened this issue 3 years ago • 4 comments

DilumAluthge avatar Aug 10 '22 23:08 DilumAluthge

Codecov Report

Merging #822 (8b0e082) into dev (856928c) will increase coverage by 0.11%. The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #822      +/-   ##
==========================================
+ Coverage   85.77%   85.89%   +0.11%     
==========================================
  Files          37       37              
  Lines        3516     3587      +71     
==========================================
+ Hits         3016     3081      +65     
- Misses        500      506       +6     
Impacted Files Coverage Δ
src/composition/learning_networks/inspection.jl 84.61% <0.00%> (-1.66%) :arrow_down:
src/measures/meta_utilities.jl 19.60% <0.00%> (-0.81%) :arrow_down:
src/composition/learning_networks/nodes.jl 70.62% <0.00%> (-0.62%) :arrow_down:
src/show.jl 37.95% <0.00%> (-0.32%) :arrow_down:
src/machines.jl 87.50% <0.00%> (-0.30%) :arrow_down:
src/resampling.jl 91.46% <0.00%> (-0.15%) :arrow_down:
src/measures/roc.jl 100.00% <0.00%> (ø)
src/composition/models/methods.jl 100.00% <0.00%> (ø)
src/composition/models/inspection.jl 100.00% <0.00%> (ø)
src/composition/models/pipelines.jl 99.43% <0.00%> (+0.01%) :arrow_up:
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 11 '22 00:08 codecov-commenter

@DilumAluthge Can this be closed now?

ablaom avatar Aug 17 '22 23:08 ablaom

Actually, we should merge this, so that we can detect if tests start failing on Julia nightly again.

DilumAluthge avatar Aug 19 '22 02:08 DilumAluthge

I guess this sounds silly, but I don't like all those red crosses I get after my commits when nightly fails, which it frequently does. That's why I disabled nightly. Is there a workaround?

ablaom avatar Aug 19 '22 04:08 ablaom

Yeah, it is unfortunate that sometimes Julia nightly is failing. The problem is that if we don't test on Julia nightly, we don't catch bugs like https://github.com/JuliaLang/julia/issues/46405 until after a new version of Julia has been released.

DilumAluthge avatar Aug 26 '22 04:08 DilumAluthge