joystream icon indicating copy to clipboard operation
joystream copied to clipboard
verified publisher icon Joystream

[Origo] Adds support to mark storage-node/distrubtion-node under maintenance

Open zeeshanakram3 opened this issue 2 years ago • 10 comments

Addresses #4765

  • [x] Adds Storage/Distribution QN mappings
  • [x] Adds operator:set-metadata & leader:set-node-operational-status CLI commands
  • [x] ~WIP: Updating Storage/Distribution related integration tests~ https://github.com/Joystream/joystream/issues/4815

zeeshanakram3 avatar Jun 21 '23 06:06 zeeshanakram3

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pioneer-testnet ⬜️ Ignored (Inspect) Jul 18, 2023 7:00am

vercel[bot] avatar Jun 21 '23 06:06 vercel[bot]

You need to add implicitly new dependency on inquirer-datepicker? (and maybe others) to storage node: this is why this check is failing building docker image for storage node https://github.com/Joystream/joystream/actions/runs/5561050023/jobs/10158465896?pr=4793#step:8:373

mnaamani avatar Jul 16 '23 23:07 mnaamani

Integration tests will be added in #4815

zeeshanakram3 avatar Jul 26 '23 09:07 zeeshanakram3

@zeeshan perhaps we can try to bump version of protobufjs in this PR?

see https://github.com/advisories/GHSA-h755-8qp9-cq85

mnaamani avatar Jul 31 '23 17:07 mnaamani

perhaps we can try to bump version of protobufjs in this PR?

Bumped package versions and updated CHANGELOG.md in d133ffb

zeeshanakram3 avatar Aug 01 '23 15:08 zeeshanakram3

perhaps we can try to bump version of protobufjs in this PR?

Bumped package versions and updated CHANGELOG.md in d133ffb

Great. I think QN package also needs a version bump.

mnaamani avatar Aug 02 '23 10:08 mnaamani

I think QN package also needs a version bump.

Done in ba24cfe

zeeshanakram3 avatar Aug 02 '23 13:08 zeeshanakram3

@kdembler I have addressed the requested changes. Also, removed the QN mappings needed for this feature as I think having the code at two places makes it difficult to review and maintain

Also, did changes as described in #4816 for both Argus/Colossus

zeeshanakram3 avatar Feb 29 '24 06:02 zeeshanakram3

@mnaamani @kdembler I have addressed the requested changes. Also, re-designed the protobuf message schemas as requested.

If the new protobuf messages are acceptable, then please publish the npm package so I would update the storage-squid mappings as well

zeeshanakram3 avatar Mar 27 '24 07:03 zeeshanakram3

@mnaamani @kdembler I have addressed the requested changes. Also, re-designed the protobuf message schemas as requested.

If the new protobuf messages are acceptable, then please publish the npm package so I would update the storage-squid mappings as well

published protobuf and joystream/js packages (for joystream/js I bumped the dependency on protobuf package)

mnaamani avatar Apr 08 '24 21:04 mnaamani