gorilla-repl icon indicating copy to clipboard operation
gorilla-repl copied to clipboard

Should reset nREPL session when loading or resetting worksheet

Open JonyEpsilon opened this issue 11 years ago • 2 comments

Not doing this results in some unexpected behaviour with namespaces. The user might think it should be bound to the worksheet, but at the moment it's actually bound to the browser tab. This means it feels a bit odd when you load or reset from a worksheet that had changed namespace.

JonyEpsilon avatar Jul 23 '14 17:07 JonyEpsilon

(sorry I posted this in the wrong issue the first time) What would this entail? Would we need to create a new websocket, or is there an op for get a clean session?

jaredly avatar Sep 08 '14 05:09 jaredly

There's an op to get a new session (clone). What needs cleaning up is the way that connect/disconnect happens with the websocket. It also would be good at the same time to resolve the connection/client/session confusion that's making interrupt #18 fail.

JonyEpsilon avatar Sep 08 '14 11:09 JonyEpsilon