JoinMarket-Org
Maker: too big miner fee contribution can lead to failed joins
Edge case, usually not happening in the wild:
Symptom: If a maker has a miner fee contribution which is higher than the fee the taker was setting for the whole transaction, the maker throws an error.
Outcome: From a taker's perspective, the maker times out. No other issues
Reason: Taker pays less fee than the maker contributes, which messes up the change amount. Most easily seen in this log fragment, seen from the taker's perspective (made relevant parts bold): [INFO ] Based on initial guess: 3286, we estimated a miner fee of: 9082 [INFO ] fee breakdown for me totalin=3536294152 my_txfee=0 makers_txfee=9768 cjfee_total=144000 => changevalue=2786150152 ... [DEBUG] <<privmsg on CgAn: nick=SomeNick message=!error Wrong cj_amount. I expect 750000000
Workaround: Since this only can happen if the tx fee contribution is higher than the whole transaction's fee, this doesnt happen in 99,99% of the cases. Might happen with a very low number of involved makers plus a very slow target confirmation time plus currently low tx fees. Probably just dont set a higher tx fee contribution than 5000 or so on your maker.
